
Code Review Best Practices and Readability

#10 - State of Java & Code Review Best Practices - Trisha Gee
Topic 5 of 7
Published Oct 12, 2020 · Clip 33:56–45:23 (11:27)
Trisha explains how her book 'What to Look for in a Code Review' grew out of JetBrains blog posts, and that code reviews serve different purposes: gateway reviews (checking correctness and tests before production), knowledge-sharing reviews, and early design reviews. She argues design feedback must come early, reviews should be small and quick, and linters should automate what machines can check. She recommends including juniors in reviews to verify readability, and describes reading-code-as-learning reviews. She also discusses her 'Reading Code is Harder than Writing It' message: we spend most of our time reading code, should value that skill, and new code should be idiomatic to the codebase's existing 'dialect.'