Code reviews, testing, and modularization

How Notion Builds Their iOS and Android Apps

Topic 9 of 14

Published Dec 11, 2024 · Clip 45:06–56:47 (11:41)

Code reviews are usually within-platform (80–90%) with occasional cross-platform PR-for-PR reviews when pairing on the same feature. Reviews are fast—a same-day SLA for longer PRs, immediate glances for short ones—and they use Graphite for stacked PRs. The small, senior team meant nearly everyone reviewed PRs, spreading codebase knowledge. On testing: early on they wrote tests only for critical service layers like transaction syncing; now they aim to test all module public APIs. Build times are healthy (~45 second clean build) thanks to heavy modularization (~100 iOS modules, ~50 Android), categorized as feature/service/model/helper/UI, enabling per-module builds, feature-sliced builds, and incremental migrations like Swift strict concurrency.